Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect associated files at beginning of workflow #246

Merged
merged 11 commits into from Mar 31, 2023

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Mar 30, 2023

Closes #237.

Changes proposed in this pull request

  • Create new function, collect_run_data to collect M0 file, M0 metadata, SBRef, and ASLContext file, as available.
    • Feed these files/metadata into the appropriate interfaces in the CBF workflows, rather than trying to get those files with simple string manipulation within the interfaces.
  • Move BIDSDataGrabber interface from niworkflows to main BIDS module.
    • Drop "func" from the search.
  • Streamline M0 extraction.
    • I still want to consolidate the GE and non-GE M0 extraction code, since it's mostly the same. The only difficulty is that non-GE M0 extraction has a mask, while GE M0 extraction will use the M0 map to make the mask later.

Documentation that should be reviewed

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 51.25% and project coverage change: +0.12 🎉

Comparison is base (075038d) 45.63% compared to head (ca7cd03) 45.76%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #246      +/-   ##
==========================================
+ Coverage   45.63%   45.76%   +0.12%     
==========================================
  Files         132      132              
  Lines       12483    12508      +25     
==========================================
+ Hits         5697     5724      +27     
+ Misses       6786     6784       -2     
Impacted Files Coverage Δ
aslprep/utils/misc.py 68.19% <ø> (+1.92%) ⬆️
aslprep/workflows/asl/ge_utils.py 18.75% <ø> (-0.55%) ⬇️
aslprep/interfaces/ge.py 25.33% <7.27%> (+0.97%) ⬆️
aslprep/workflows/asl/gecbf.py 14.78% <11.11%> (+0.12%) ⬆️
aslprep/interfaces/cbf_computation.py 69.30% <54.54%> (+0.51%) ⬆️
aslprep/utils/bids.py 54.36% <68.42%> (+3.68%) ⬆️
aslprep/interfaces/bids.py 96.42% <94.44%> (-3.58%) ⬇️
aslprep/workflows/asl/base.py 79.48% <100.00%> (+1.86%) ⬆️
aslprep/workflows/asl/cbf.py 59.52% <100.00%> (+0.35%) ⬆️
aslprep/workflows/base.py 88.75% <100.00%> (+0.14%) ⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tsalo tsalo marked this pull request as ready for review March 31, 2023 23:33
@tsalo tsalo merged commit ea0d0e1 into PennLINC:main Mar 31, 2023
9 checks passed
@tsalo tsalo deleted the bidsdatagrabber branch March 31, 2023 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collect associated files for ASL file in a single step
2 participants