Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Index aslcontext rows with "cbf", not "CBF" #252

Merged
merged 1 commit into from Apr 4, 2023

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Apr 4, 2023

Closes None.

Changes proposed in this pull request

  • In sections where the aslcontext file is indexed to find CBF volumes, the code originally looked for "CBF", but the BIDS spec only allows "cbf".

@tsalo tsalo added the bug Something isn't working label Apr 4, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (6a231e1) 50.94% compared to head (b58e388) 50.94%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #252   +/-   ##
=======================================
  Coverage   50.94%   50.94%           
=======================================
  Files         132      132           
  Lines       12595    12595           
=======================================
  Hits         6417     6417           
  Misses       6178     6178           
Impacted Files Coverage Δ
aslprep/interfaces/cbf_computation.py 83.55% <100.00%> (ø)
aslprep/interfaces/ge.py 62.22% <100.00%> (ø)
aslprep/workflows/asl/cbf.py 83.43% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tsalo tsalo merged commit 2151899 into PennLINC:main Apr 4, 2023
20 checks passed
@tsalo tsalo deleted the cbf-in-aslcontext branch April 4, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants