New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] ENH: 482 remove fsl dependency #498
Conversation
Ready for re-review of remaining changes (mostly FAST removal related) when you are @mattcieslak |
I noticed that you removed t1_seg from a lot of these workflows. With #553 the t1_seg will be available no matter what, so I'm thinking it would make sense to let the tests fail on this build but keep t1_seg the way it was before in the dwi workflows. If you revert those, we can merge this into master and then I'll merge it into #553. wdyt? |
Good point, that works for me! I'll let you know when it's put back in. Ok to still leave out the TPMs or should those be added back as well? |
Awesome! The TPMs are never used, so those can stay out |
Ok, I added all the segmentation node inputs back in. Things to note: Let me know if any other changes are necessary. |
It worked?!? If you can run this on a real test dataset and the results look good, I'll go ahead and merge! |
The most recent version of the master branch is already included here, so if this branch works it will become the master branch when we merge it |
awesome!! letting Joey hit the final button... |
Changes proposed in this pull request
Replacement of FSL tools when replacements are available, for example replacing BET with ANTs BrainExtraction. For FSL tools with no viable replacements (mainly FUGUE and PRELUDE) we add a check for FSL environment variables such that containers without FSL can't run them, and those who still want to use FSL are able to. A separate container without FSL will be generated to give users a choice between qsiprep installations with or without FSL installed.
Documentation that should be reviewed
Boilerplate and references require updating to match the removed or replaced FSL functions.