[FIX] remove pre bids-filter acq type argument #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's not a bad idea, fmriprep for example lets you use a command line flag But I agree it shouldn't be able to silently not work, might be best to remove unless there's user interest in implementing it. |
|
@octomike thanks for bringing this up. There are too many arguments to qsiprep anyways, happy to lose one that didn't do anything |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm debugging an issue and found that this option is present in the cli code, but never used anywhere. This was added in d08a171 and I assume it was made obsolete with the
bids-filter-fileargument?I was about to use this option when I figured out it would have made no difference anyway and I want to save others from falling into this little trap.