Refactors createTileObjects function #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| self.objectIndex[location] = (new QuadArc(location, orientation)); | ||
| break; | ||
| } | ||
| self.objectIndex[location] = new shapes[shapeType](location, orientation); |
There was a problem hiding this comment.
Super cool refactor, I'm all about stuffing classes into objects. I think I'd prefer if the object were named 'shape' or even 'shapeOfType' rather than 'shapes' so you can say 'new shape[shapeType]...' or 'new shapeOfType[shapeType]...'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I pulled the shapes out into their own array and eliminated the switch statement in this function, replacing it with one line of dynamic code.
@bethsebian @rrgayhart @afg419