Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiverse ID is not correctly populated #25

Closed
bakert opened this issue Sep 27, 2016 · 4 comments
Closed

Multiverse ID is not correctly populated #25

bakert opened this issue Sep 27, 2016 · 4 comments
Assignees
@bakert
Labels
+ bug

Comments

@bakert
Copy link
Member

bakert commented Sep 27, 2016

multiverse_id = cards[0].multiverse_id is not working with cards retrieved from the db so fallback images will fail. Multiverse id doesn't seem to be populated in the db.
@silasary
Copy link
Member

It's not currently populated in the source JSON itself.

@silasary silasary added the + bug label Sep 27, 2016
@bakert
Copy link
Member Author

bakert commented Sep 27, 2016

I'm pretty sure magicthegathering.io is built on top of mtgjson.com and that was able to retrieve multiverse id so there's something weird going on here ...

@bakert
Copy link
Member Author

bakert commented Sep 27, 2016

multiverse_id is in AllSets.json. It is NOT in AllCards.json. We should probably build the db from AllSets.json.

@silasary silasary mentioned this issue Sep 29, 2016
Closed
@bakert bakert self-assigned this Sep 29, 2016
@bakert
Copy link
Member Author

bakert commented Oct 2, 2016

This is now in the printing table.

@bakert bakert closed this as completed Oct 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bakert bakert

Labels
+ bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bakert @silasary