Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add opengraph data to /tournaments/ and other marquee pages. #5066

Open
vorpal-buildbot opened this issue Jul 20, 2018 · 4 comments
Open

add opengraph data to /tournaments/ and other marquee pages. #5066

vorpal-buildbot opened this issue Jul 20, 2018 · 4 comments
Labels
- backlog Non-urgent tasks deferred until someone wants to work on them * decks pennydreadfulmagic.com (but use more specific label if available) good first issue GitHub-mandated label for potential contributors + improvement Improvement of existing functionality

Comments

@vorpal-buildbot
Copy link
Contributor

Reported on Discord by silasary#0001
@triage-new-issues triage-new-issues bot added the triage Used by bot to label unlabeled tasks, will be removed automatically upon labeling label Jul 20, 2018
@bakert
Copy link
Member

bakert commented Jul 21, 2018

This sounds cool/good but I don't quite understand it from reading our existing oembed code.

@bakert
Copy link
Member

bakert commented Jul 23, 2018

Discord dev comment (from a couple years ago):

https://www.reddit.com/r/discordapp/comments/4g5taw/are_link_preview_images_only_for_whitelisted_sites/d2f1jnb/

@bakert
Copy link
Member

bakert commented Jul 23, 2018

Note we have an existing implementation (working?) for deck detail page.

@silasary
Copy link
Member

Yeah, we just need to add the data for non-deck pages.

@bakert bakert added + improvement Improvement of existing functionality * decks pennydreadfulmagic.com (but use more specific label if available) labels Jul 30, 2018
@triage-new-issues triage-new-issues bot removed triage Used by bot to label unlabeled tasks, will be removed automatically upon labeling labels Jul 30, 2018
@bakert bakert added the - backlog Non-urgent tasks deferred until someone wants to work on them label Aug 24, 2018
@silasary silasary added the good first issue GitHub-mandated label for potential contributors label Sep 8, 2018
@silasary silasary changed the title add oembed data to /tournaments/ and other marquee pages. add opengraph data to /tournaments/ and other marquee pages. Sep 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
- backlog Non-urgent tasks deferred until someone wants to work on them * decks pennydreadfulmagic.com (but use more specific label if available) good first issue GitHub-mandated label for potential contributors + improvement Improvement of existing functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bakert @silasary @vorpal-buildbot