-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Runtime] Allow runtime to be compiled in ILP32 mode. #230
Conversation
Codecov Report
@@ Coverage Diff @@
## main #230 +/- ##
==========================================
- Coverage 99.22% 99.22% -0.01%
==========================================
Files 37 37
Lines 6699 6697 -2
Branches 340 340
==========================================
- Hits 6647 6645 -2
Misses 29 29
Partials 23 23
|
@maliasadi I think we don't need a change log for this one, what do you think? |
Always good to add a changelog :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @erick-xanadu! Don't forget to check other devices (lightning-kokkos, openqasm) too.
I think it's good to add this for the future reference. |
What do you mean here? Wouldn't the CI/CD tests cover these? |
You may need to update other devices Obs Manager classes after building catalyst with those backend devices on our local MacOS arm64 device. CI/CD checks all the devices but not on MacOS arm64 yet. |
Got it. They all unconditionally get compiled, correct? If that's the case, then since this is a compile time error, this patch should be sufficient. |
You still need to check/update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
[sc-43392] |
Context: Error seen when compiling on macOS arm64
Description of the Change: Remove reinterpret_cast
Benefits: Can compile with ILP32 mode (used by macOS)