-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Frontend] JAX tracer supporting user-defined tape transformation #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #240 +/- ##
==========================================
+ Coverage 99.47% 99.51% +0.04%
==========================================
Files 41 40 -1
Lines 7192 7196 +4
Branches 386 410 +24
==========================================
+ Hits 7154 7161 +7
+ Misses 20 17 -3
Partials 18 18
☔ View full report in Codecov by Sentry. |
Co-authored-by: David Ittah <dime10@users.noreply.github.com>
grwlf
force-pushed
the
tape-transform
branch
from
September 21, 2023 11:03
4cb64da
to
ccb05fa
Compare
grwlf
force-pushed
the
tape-transform
branch
from
September 21, 2023 11:39
82336f2
to
0597b4d
Compare
grwlf
force-pushed
the
tape-transform
branch
from
September 21, 2023 13:17
c49be33
to
de88012
Compare
grwlf
force-pushed
the
tape-transform
branch
from
September 21, 2023 15:07
44bb004
to
be76e42
Compare
dime10
approved these changes
Sep 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 💯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we aim at making it possible to apply user-defined transformations to a tape containing Catalyst quantum operators. The main difficulty is related to the fact that in Catalyst we only trace programs rather than execute them so the operations on tape: (1) are filled with abstract parameters, (2) include control flow operations containing nested tapes.
The approach we are working on would essentially split the tracing process into classical and quantum parts. In order to do so, we store JAX tracing contexts and re-enter them as needed. We described the idea and the associated risks in the internal document.
Tasks:
[sc-41345]