New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Braket Devices enums and S3 buckets #278
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #278 +/- ##
=======================================
Coverage 99.31% 99.31%
=======================================
Files 41 41
Lines 7141 7157 +16
Branches 377 377
=======================================
+ Hits 7092 7108 +16
Misses 27 27
Partials 22 22
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @maliasadi 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks @maliasadi!
I have a separate question: your ADR on allowing devices to specifying compilation options. Would it be sufficient in allowing this logic here to not be hardcoded into the Catalyst functions?
@josh146 the PS. I've included this to the ADR for re-considering it while refactoring the frontend. |
Thanks @maliasadi!
Over time we will run into this issue with other devices as well. Even lightning has additional options you can pass it -- e.g., for MCMC sampling: dev = qml.device("lightning.qubit", wires=2, shots=1000, mcmc=True, kernel_name="NonZeroRandom", num_burnin=200) |
Context:
This PR fixes #206 by adding support for
s3_destination_folder
in remote calls.[sc-45094]