[Build system] Remove unneeded dependencies #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ever since the compiler driver, we no longer depend on opt. Save on compile time.
erick-xanadu
force-pushed
the
eochoa/2023-10-03/small-fixes
branch
from
9292a1f
to
95e01f7
Compare
|
@erick-xanadu not related to this PR, but I found another issue with mlir/Makefile that'd be nice to fix as part of this PR (instead of creating a new one). Could you fix the all target at .PHONY: all
-all: llvm mhlo dialects enzyme
+all: llvm mhlo enzyme dialectsIt looks good otherwise. |
maliasadi
approved these changes
Oct 10, 2023
erick-xanadu
force-pushed
the
eochoa/2023-10-03/small-fixes
branch
from
7c2a6c8
to
505db22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: LLVM's
optis no longer a dependency. Python'swheelpackage is also not a dependency.Description of the Change: Remove them from the build wheel action.
Benefits: Less time spent on the action.
Note: Test the wheel before merging. Wheels passed: https://github.com/PennyLaneAI/catalyst/actions/runs/6434485404
[sc-47316]