Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Runtime] Fixes the issue with missing CFP_t #322

Merged
merged 5 commits into from
Oct 18, 2023
Merged

Conversation

maliasadi
Copy link
Member

This fixes the issue with building StateVectorLQubitDynamic against the master branch of the lightning monorepo after merging PR PennyLaneAI/pennylane-lightning#499.

@maliasadi maliasadi requested a review from dime10 October 18, 2023 20:27
@dime10
Copy link
Collaborator

dime10 commented Oct 18, 2023

Thanks @maliasadi, let's add a changelog and add the reference commit hash (from the lightning repo) that this fix is targeting to our makefile (instead of the current "master" tag). This will allow us to go back through our git history in the future and still have reproduceable runtime builds :)

doc/changelog.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@dime10 dime10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for the quick fix 💪

doc/changelog.md Outdated Show resolved Hide resolved
@rmoyard rmoyard merged commit 9e99732 into main Oct 18, 2023
18 checks passed
@rmoyard rmoyard deleted the runtime/fix-cfp-t-issue branch October 18, 2023 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants