Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MLIR] Support dynamic memref shape in the cp-global-memref pass #348

Merged
merged 3 commits into from
Nov 2, 2023
Merged

[MLIR] Support dynamic memref shape in the cp-global-memref pass #348

merged 3 commits into from
Nov 2, 2023
+56 −3

Conversation

sergei-mironov
Copy link
Contributor

In this PR we add the dynamic shape support (memref<?x?xf32>) to the cp-global-memref pass.

@sergei-mironov sergei-mironov marked this pull request as ready for review November 2, 2023 12:28
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 2, 2023

Hello. You may have forgotten to update the changelog!
Please edit doc/changelog.md on your branch with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

dime10
dime10 approved these changes Nov 2, 2023
View reviewed changes
Copy link
Collaborator

@dime10 dime10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find 💯 ( Don't forget a changelog :) )

@sergei-mironov sergei-mironov merged commit 5d818b7 into main Nov 2, 2023
18 checks passed
@sergei-mironov sergei-mironov deleted the cp-memref-supports-dynshape branch November 2, 2023 15:04
@sergei-mironov sergei-mironov restored the cp-memref-supports-dynshape branch November 2, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dime10 dime10 dime10 approved these changes

@erick-xanadu erick-xanadu Awaiting requested review from erick-xanadu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sergei-mironov @dime10