New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Frontend] Refactor compiler #38
Conversation
2f99792
to
45af322
Compare
e62d0d6
to
92735d2
Compare
Codecov Report
@@ Coverage Diff @@
## main #38 +/- ##
==========================================
+ Coverage 98.24% 98.71% +0.46%
==========================================
Files 34 34
Lines 5532 5531 -1
Branches 261 265 +4
==========================================
+ Hits 5435 5460 +25
+ Misses 55 40 -15
+ Partials 42 31 -11
... and 9 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
4ca4d0f
to
8316174
Compare
8316174
to
fd6c3dc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work, really like the redesign of the compiler script into something more structured 💯
96f53eb
to
f46294e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @erick-xanadu! I really like our brand new classified compiler 😄 Just re-reviewed my earlier review and there isn't much more to add. A few minor suggestions but it should be good to be merged from my side.
Co-authored-by: Ali Asadi <ali@xanadu.ai>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 💯
Co-authored-by: David Ittah <dime10@users.noreply.github.com> Co-authored-by: Ali Asadi <ali@xanadu.ai>
This reverts commit 0ca30d5.
Context: Prepares changes for allowing easier debugging. The idea to improve debugging is to allow easy prototypes of new compilation pipelines which may circumvent some of the default behaviour. For example, instead of generating the MLIR module from python, load it from a string. Instead of generating LLVM-IR, load it from a file. These debugging changes are not yet implemented, but these will be implemented on top of this refactoring.
Description of the Change:
Benefits: Treats the compiler as a library and allows prototyping alternative compilation flows.
[sc-36252]