Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add shot-noise to measurement #392

Merged
merged 20 commits into from
Dec 14, 2023
Merged

add shot-noise to measurement #392

merged 20 commits into from
Dec 14, 2023

Conversation

multiphaseCFD
Copy link
Member

@multiphaseCFD multiphaseCFD commented Dec 5, 2023

This PR adds support for finite-shot measurement statistics (expval, var, and probs) for lightning.qubit and lightning.kokkos devices.

[sc-46423]

@maliasadi maliasadi added the runtime Pull requests that update the runtime label Dec 6, 2023
@maliasadi maliasadi marked this pull request as ready for review December 12, 2023 21:34
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ea1c7b7) 99.54% compared to head (f9c3063) 99.56%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #392      +/-   ##
==========================================
+ Coverage   99.54%   99.56%   +0.01%     
==========================================
  Files          43       43              
  Lines        7302     7546     +244     
  Branches      497      497              
==========================================
+ Hits         7269     7513     +244     
  Misses         17       17              
  Partials       16       16              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

doc/changelog.md Outdated Show resolved Hide resolved
@josh146
Copy link
Member

josh146 commented Dec 13, 2023

This is great @multiphaseCFD @maliasadi, great work!

Something I do wonder about though is testing. We know from experience that there are a lot of edge cases for measurements, such as:

  • Single observables
  • tensors on different wires
  • linear combinations/hamiltonians
  • new operator arithmetic
  • differentiation
  • expval/var

Should we have more extensive testing here?

Copy link
Collaborator

@dime10 dime10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 👍

.github/workflows/build-wheel-linux-x86_64.yaml Outdated Show resolved Hide resolved
doc/dev/quick_start.rst Outdated Show resolved Hide resolved
frontend/test/pytest/test_measurements_results.py Outdated Show resolved Hide resolved
frontend/test/pytest/test_pytree_args.py Outdated Show resolved Hide resolved
runtime/README.rst Outdated Show resolved Hide resolved
doc/changelog.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@dime10 dime10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Member

@maliasadi maliasadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @multiphaseCFD! 💯

@multiphaseCFD multiphaseCFD merged commit 9f87218 into main Dec 14, 2023
23 checks passed
@multiphaseCFD multiphaseCFD deleted the lightning_obs_shots branch December 14, 2023 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
runtime Pull requests that update the runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants