-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add shot-noise to measurement #392
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #392 +/- ##
==========================================
+ Coverage 99.54% 99.56% +0.01%
==========================================
Files 43 43
Lines 7302 7546 +244
Branches 497 497
==========================================
+ Hits 7269 7513 +244
Misses 17 17
Partials 16 16 ☔ View full report in Codecov by Sentry. |
This is great @multiphaseCFD @maliasadi, great work! Something I do wonder about though is testing. We know from experience that there are a lot of edge cases for measurements, such as:
Should we have more extensive testing here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @multiphaseCFD! 💯
This PR adds support for finite-shot measurement statistics (
expval
,var
, andprobs
) forlightning.qubit
andlightning.kokkos
devices.[sc-46423]