Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Frontend] Refactor call tree verification for Grad #399

Merged
merged 3 commits into from
Dec 7, 2023

Conversation

dime10
Copy link
Collaborator

@dime10 dime10 commented Dec 7, 2023

The primitives for Function and Grad have been changed to bind the callee, instead of the object instance itself.
Additionally, the call tree traversal of the callee has been improved to be more robust.

No (external) functional changes.

The primitives for Function and Grad have been changed to bind the
callee, instead of the object instance itself.
Additionally, the call tree traversal of the callee has been improved to
be more robust.

No (external) functional changes.
Copy link
Contributor

@erick-xanadu erick-xanadu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐞

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (de8a59f) 99.50% compared to head (59f1607) 99.48%.
Report is 1 commits behind head on main.

Files Patch % Lines
frontend/catalyst/pennylane_extensions.py 90.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #399      +/-   ##
==========================================
- Coverage   99.50%   99.48%   -0.02%     
==========================================
  Files          42       42              
  Lines        7048     7053       +5     
  Branches      476      477       +1     
==========================================
+ Hits         7013     7017       +4     
  Misses         20       20              
- Partials       15       16       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Dec 7, 2023

Hello. You may have forgotten to update the changelog!
Please edit doc/changelog.md on your branch with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@maliasadi maliasadi added the frontend Pull requests that update the frontend label Dec 7, 2023
@dime10 dime10 merged commit 88bd0e2 into main Dec 7, 2023
32 of 34 checks passed
@dime10 dime10 deleted the grad-tree-traversal-fix branch December 7, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Pull requests that update the frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants