Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Frontend] Split jax_extras into several modules #505

Merged
merged 13 commits into from
Feb 23, 2024

Conversation

sergei-mironov
Copy link
Contributor

This is an utility PR split ./utils/jax_extras.py into three sub-modules. The goal is to make a complex #370 PR simpler.

@sergei-mironov sergei-mironov changed the title Split jax_extras into several modules [Frontend] Split jax_extras into several modules Feb 12, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.55%. Comparing base (0f7eaba) to head (f5f9c17).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #505   +/-   ##
=======================================
  Coverage   99.54%   99.55%           
=======================================
  Files          49       52    +3     
  Lines        8434     8455   +21     
  Branches      558      558           
=======================================
+ Hits         8396     8417   +21     
  Misses         20       20           
  Partials       18       18           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergei-mironov sergei-mironov marked this pull request as ready for review February 12, 2024 14:04
Copy link

Hello. You may have forgotten to update the changelog!
Please edit doc/changelog.md on your branch with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@sergei-mironov sergei-mironov added the runtime Pull requests that update the runtime label Feb 12, 2024
@sergei-mironov sergei-mironov self-assigned this Feb 12, 2024
@sergei-mironov sergei-mironov added frontend Pull requests that update the frontend and removed runtime Pull requests that update the runtime labels Feb 12, 2024
Co-authored-by: erick-xanadu <110487834+erick-xanadu@users.noreply.github.com>
Copy link
Contributor

@erick-xanadu erick-xanadu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just add a reference to the PR so that it can be visible in the code.

Thanks @grwlf!

@sergei-mironov sergei-mironov merged commit 87aed48 into main Feb 23, 2024
34 checks passed
@sergei-mironov sergei-mironov deleted the dynshape-split-jax-extras branch February 23, 2024 15:31
rauletorresc pushed a commit that referenced this pull request Feb 26, 2024
This is an utility PR split `./utils/jax_extras.py` into three
sub-modules. The goal is to make a complex
#370 PR simpler.

---------

Co-authored-by: erick-xanadu <110487834+erick-xanadu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Pull requests that update the frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants