Implement reset feature for mid-circuit measurements #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauletorresc
added
runtime
rauletorresc
requested review from
sergei-mironov,
maliasadi,
dime10,
rmoyard and
erick-xanadu
rauletorresc
force-pushed
the
implement-reset-at-measure
branch
3 times, most recently
from
cc7dfb0
to
cd5f8d7
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #507 +/- ##
=======================================
Coverage 99.55% 99.55%
=======================================
Files 43 43
Lines 7866 7870 +4
Branches 537 537
=======================================
+ Hits 7831 7835 +4
Misses 18 18
Partials 17 17 ☔ View full report in Codecov by Sentry. |
rauletorresc
force-pushed
the
implement-reset-at-measure
branch
from
a97b236
to
db74f1e
Compare
rauletorresc
removed
runtime
maliasadi
reviewed
Feb 15, 2024
maliasadi
reviewed
Feb 15, 2024
maliasadi
reviewed
Feb 15, 2024
rauletorresc
force-pushed
the
implement-reset-at-measure
branch
from
db74f1e
to
f9c8b45
Compare
rauletorresc
added
the
ci:build-wheels
rauletorresc
force-pushed
the
implement-reset-at-measure
branch
from
f9c8b45
to
b849cec
Compare
|
The coverage does seem bugged, I think we can merge as is 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: We want to support in Catalyst the existent reset feature of the measure function of PennyLane.
Description of the Change: The logic is implemented at the measure function right after the instantiation of the MidCircuitMeasure object. It applies a PauliX gate to the qubit, but only if the measurement result was 1.
Benefits: No need to involve MLIR and runtime on the process.
TODO:
[sc-56696]