Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes short names to match. #547

Merged
merged 3 commits into from
Feb 26, 2024
Merged

Fixes short names to match. #547

merged 3 commits into from
Feb 26, 2024

Conversation

erick-xanadu
Copy link
Contributor

Fix short names in setup.py

@github-actions GitHub Actions
Copy link

Hello. You may have forgotten to update the changelog!
Please edit doc/changelog.md on your branch with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

dime10
dime10 approved these changes Feb 26, 2024
View reviewed changes
Copy link
Collaborator

@dime10 dime10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add it to the CUDA changelog entry? :)

josh146
josh146 approved these changes Feb 26, 2024
View reviewed changes
Copy link
Member

@josh146 josh146 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @erick-xanadu! just echoing @dime10 on adding it to the changelog entry

@josh146 josh146 added this to the v0.5.0 milestone Feb 26, 2024
@erick-xanadu erick-xanadu merged commit 7781c68 into main Feb 26, 2024
34 checks passed
@erick-xanadu erick-xanadu deleted the eochoa/2024-02-26/fix-short-name branch February 26, 2024 16:37
rauletorresc pushed a commit that referenced this pull request Feb 26, 2024
@erick-xanadu @rauletorresc
Fixes short names to match. (#547)
fe11825 
Fix short names in setup.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josh146 josh146 josh146 approved these changes

@dime10 dime10 dime10 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@erick-xanadu @josh146 @dime10