Verify static argnums during program capture #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation verified the argnums during QJIT construction, which only works if the number of arguments is known ahead of time.
dime10
added
bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #550 +/- ##
=======================================
Coverage 99.56% 99.56%
=======================================
Files 52 52
Lines 8510 8511 +1
Branches 568 568
=======================================
+ Hits 8473 8474 +1
Misses 20 20
Partials 17 17 ☔ View full report in Codecov by Sentry. |
rauletorresc
pushed a commit
that referenced
this pull request
Feb 26, 2024
The previous implementation verified the argnums during QJIT construction, which only works if the number of arguments is known ahead of time. closes #548
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation verified the argnums during QJIT
construction, which only works if the number of arguments is known
ahead of time.
closes #548