Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OQC device (C++) #579

Merged
merged 160 commits into from Mar 28, 2024
Merged

OQC device (C++) #579

merged 160 commits into from Mar 28, 2024

Conversation

rmoyard
Copy link
Contributor

@rmoyard rmoyard commented Mar 4, 2024 •
edited

Context:
After adding the Python layer for the OQC device, we add the C++ layer.

Description of the Change:

  1. We generate QASM2 at runtime. We have implemented a builder for QASM2, similar to the QASM3 that we use for braket.
  2. We implement a OQC runner that goes back to Python and send the generated QASM to the OQC cloud thanks to oqc qcaas cloud.
  3. The OQC device is implemented and use the builder and the runner. Only counts are supported because we implement a transform decomposition in the frontend. Transform: measurements to counts #608

make oqc
make test-oqc

Benefits:
New Catalyst device.

TODO

Entrypoints

@rmoyard rmoyard changed the base branch from main to python_oqc March 4, 2024 18:04
maliasadi
maliasadi reviewed Mar 22, 2024
View reviewed changes
.github/workflows/build-wheel-macos-x86_64.yaml Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
maliasadi
maliasadi reviewed Mar 22, 2024
View reviewed changes
Makefile Outdated Show resolved Hide resolved
rmoyard and others added 3 commits March 22, 2024 16:24
@rmoyard @maliasadi
Update Makefile
e614b01 
Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com>
@rmoyard
Update path
3ed9495
@rmoyard
Fix oqc test path
614c472
maliasadi
maliasadi approved these changes Mar 28, 2024
View reviewed changes
Copy link
Member

@maliasadi maliasadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 🪂

frontend/catalyst/oqc/src/OQCDevice.hpp Outdated Show resolved Hide resolved
rmoyard and others added 2 commits March 28, 2024 17:15
@rmoyard @maliasadi
Update frontend/catalyst/oqc/src/OQCDevice.hpp
d3eafe8 
Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com>
@rmoyard
Merge branch 'main' into cpp_oqc
af1c279
@rmoyard rmoyard enabled auto-merge (squash) March 28, 2024 21:15
@rmoyard rmoyard removed the requires-wheel-builds Pull Requests will need wheel building job successful before being merged label Mar 28, 2024
@rmoyard rmoyard merged commit 72698d8 into main Mar 28, 2024
36 of 38 checks passed
@rmoyard rmoyard deleted the cpp_oqc branch March 28, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dime10 dime10 dime10 left review comments

@maliasadi maliasadi maliasadi approved these changes

@erick-xanadu erick-xanadu Awaiting requested review from erick-xanadu

Assignees
No one assigned
Labels
ci:build-wheels Run the wheel building workflows on this Pull Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rmoyard @maliasadi @dime10 @erick-xanadu