Remove deprecated qfunc decorator
#679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test has been skipped because the CI does not always build the dummy device. Additionally, the test no longer works since it has gone out of date with device infrastructure changes in Catalyst & Lightning. Changes include: - inherit most properties from the lightning device rather than the dummy device - modify the supported gate set on the fly both in the device & a temporary toml file - eliminate use of the qfunc decorator - re-enable the test
.. as it is testing outdated infrastructure: - using the qfunc primitive to bypass the QJITDevice logic - bypasses the TOML logic An end-to-end test of fully unknown operation support would require the removal of the fixed runtime gate-set limitation.
.. to use new device infrastructure. Tests have also been updated to expect MultiControlledX to QubitUnitary decomposition instead of Toffoli gate sequences.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #679 +/- ##
==========================================
+ Coverage 99.14% 99.17% +0.03%
==========================================
Files 59 59
Lines 9207 9201 -6
Branches 718 718
==========================================
- Hits 9128 9125 -3
+ Misses 53 50 -3
Partials 26 26 ☔ View full report in Codecov by Sentry. |
Prevent the class from being instantiated. Pylint warnings about missing members are silenced since those members are coming from the QNode class.
erick-xanadu
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the Frontend refactor this PR removes the deprecated
@qfuncdecorator that has remained in use for internal testing (specifically lit testing). However, its use is actually very misleading since it bypasses a lot of the new infrastructure around devices and decomposition. Tests have been updated or removed.[sc-59509]