Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix return types #686

Merged
merged 5 commits into from
Apr 26, 2024
Merged

Fix return types #686

merged 5 commits into from
Apr 26, 2024

Conversation

erick-xanadu
Copy link
Contributor

Context: Callbacks was incorrectly returning a list when it should return scalar values.

Description of the Change: Does not modify the shape of the return type pytrees.

Benefits: Fixes issue seen

Possible Drawbacks: None

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.15%. Comparing base (539ff43) to head (6046d83).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #686      +/-   ##
==========================================
- Coverage   99.15%   99.15%   -0.01%     
==========================================
  Files          64       64              
  Lines        9259     9258       -1     
  Branches      719      718       -1     
==========================================
- Hits         9181     9180       -1     
  Misses         51       51              
  Partials       27       27              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@isaacdevlugt isaacdevlugt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks @erick-xanadu 👍

@erick-xanadu erick-xanadu merged commit 2dc781f into main Apr 26, 2024
38 checks passed
@erick-xanadu erick-xanadu deleted the eochoa/2024-04-26/fix-return-types branch April 26, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants