Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding more tests for callback gradients #847

Merged
merged 3 commits into from
Jun 21, 2024
Merged

Adding more tests for callback gradients #847

merged 3 commits into from
Jun 21, 2024

Conversation

erick-xanadu
Copy link
Contributor

Just adding more tests

@github-actions GitHub Actions
Copy link

Hello. You may have forgotten to update the changelog!
Please edit doc/changelog.md on your branch with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@erick-xanadu erick-xanadu marked this pull request as ready for review June 21, 2024 19:59
dime10
dime10 approved these changes Jun 21, 2024
View reviewed changes
Copy link
Collaborator

@dime10 dime10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

frontend/test/pytest/test_callback.py Show resolved Hide resolved
@erick-xanadu erick-xanadu merged commit 56468af into main Jun 21, 2024
45 checks passed
@erick-xanadu erick-xanadu deleted the eochoa/2024-06-21/tests-callback-grad branch June 21, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dime10 dime10 dime10 approved these changes

@josh146 josh146 Awaiting requested review from josh146

@rauletorresc rauletorresc Awaiting requested review from rauletorresc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@erick-xanadu @dime10