Cirq changed initial_state kwarg to be density matrix
#101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #101 +/- ##
===========================================
+ Coverage 0.00% 99.23% +99.23%
===========================================
Files 8 8
Lines 379 391 +12
===========================================
+ Hits 0 388 +388
+ Misses 379 3 -376
Continue to review full report at Codecov.
|
Jaybsoni
commented
Apr 19, 2022
Jaybsoni
changed the title
initial_state kwarg to be density matrix
Jaybsoni
commented
Apr 19, 2022
pennylane_cirq/simulator_device.py
Outdated
Comment on lines
190
to
194
| def _convert_to_density_matrix(self, state_vec): | ||
| """Convert ``state_vec`` into a density matrix.""" | ||
| dim = 2**self.num_wires | ||
| return np.kron(state_vec, state_vec.conj()).reshape((dim, dim)) | ||
|
|
There was a problem hiding this comment.
This is moved, but the MixedStateSimulatorDevice inherits from the base SimulatorDevice so both classes have access to this helper function.
rmoyard
approved these changes
Apr 19, 2022
|
[sc-17246] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling the
simulator.simulate(circuit)method forcirq.DensityMatrixSimulator()simulator (and all mixed state simulators I assume), the kwarginitial_state=Nonewas previously passed as a state vector. Now it is required that this quantity be passed as a density matrix.The unit tests were updated to make use of this functionality. No other changes required