Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated requirements.txt files #102

Merged
merged 13 commits into from
May 4, 2022
Merged

Updated requirements.txt files #102

merged 13 commits into from
May 4, 2022

Conversation

Jaybsoni
Copy link
Contributor

Updated the requirements.txt file by pinning the version #s for the dependancies. This way we ensure that users can use pip install -r requirements.txt and get a stable version of the plugin. A similar change is made for the requirements file in the docs folder.

Finally, a new requirements-ci.txt is added for our ci pipeline so that we can install the latest version of the dependancies and update the plugins accordingly.

@codecov
Copy link

codecov bot commented Apr 19, 2022

Codecov Report

Merging #102 (7309c1f) into master (629b0bc) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #102   +/-   ##
=======================================
  Coverage   99.23%   99.23%           
=======================================
  Files           8        8           
  Lines         391      391           
=======================================
  Hits          388      388           
  Misses          3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 629b0bc...7309c1f. Read the comment docs.

Copy link
Contributor

@rmoyard rmoyard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should be able to pass the doc ci check, you just need to adapt some dependencies number e.g. numpy. If you are not sure, go on action and take a look at the previous successful run and what was the version number of failing packages.

doc/requirements.txt Outdated Show resolved Hide resolved
@antalszava
Copy link
Contributor

[sc-17333]

@Jaybsoni Jaybsoni requested a review from rmoyard April 28, 2022 21:56
Copy link
Contributor

@rmoyard rmoyard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Jaybsoni, it looks good expect the `requirements-ci.txt, look at my related comment.

@@ -0,0 +1,56 @@
appdirs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here as discussed in the meeting, you should have only direct dependencies ```

pennylane
cirq-core
cirq-pasqal
numpy

requirements-ci.txt Outdated Show resolved Hide resolved
@Jaybsoni Jaybsoni requested a review from rmoyard May 2, 2022 23:16
Copy link
Contributor

@rmoyard rmoyard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Jaybsoni, it looks good to me 💯

@Jaybsoni Jaybsoni merged commit cb6defa into master May 4, 2022
@Jaybsoni Jaybsoni deleted the requirements_update branch May 4, 2022 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants