-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated requirements.txt files #102
Conversation
Codecov Report
@@ Coverage Diff @@
## master #102 +/- ##
=======================================
Coverage 99.23% 99.23%
=======================================
Files 8 8
Lines 391 391
=======================================
Hits 388 388
Misses 3 3 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should be able to pass the doc ci check, you just need to adapt some dependencies number e.g. numpy. If you are not sure, go on action and take a look at the previous successful run and what was the version number of failing packages.
[sc-17333] |
…pennylane-cirq into requirements_update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Jaybsoni, it looks good expect the `requirements-ci.txt, look at my related comment.
requirements-ci.txt
Outdated
@@ -0,0 +1,56 @@ | |||
appdirs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here as discussed in the meeting, you should have only direct dependencies ```
pennylane
cirq-core
cirq-pasqal
numpy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Jaybsoni, it looks good to me 💯
Updated the
requirements.txt
file by pinning the version #s for the dependancies. This way we ensure that users can usepip install -r requirements.txt
and get a stable version of the plugin. A similar change is made for the requirements file in the docs folder.Finally, a new
requirements-ci.txt
is added for our ci pipeline so that we can install the latest version of the dependancies and update the plugins accordingly.