Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define returns_state in capabilities #107

Merged
merged 10 commits into from
Jun 12, 2022
Merged

Define returns_state in capabilities #107

merged 10 commits into from
Jun 12, 2022

Conversation

antalszava
Copy link
Contributor

The Cirq devices that define the state method are capable of returning the state, yet they don't have the returns_state=True entry in the capabilities dictionary of the device (see the explanation of capabilities here).

@codecov
Copy link

codecov bot commented Jun 8, 2022

Codecov Report

Merging #107 (61583e8) into master (ad95aad) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #107      +/-   ##
==========================================
+ Coverage   99.23%   99.24%   +0.01%     
==========================================
  Files           8        8              
  Lines         391      397       +6     
==========================================
+ Hits          388      394       +6     
  Misses          3        3              
Impacted Files Coverage Δ
pennylane_cirq/qsim_device.py 96.87% <100.00%> (-0.10%) ⬇️
pennylane_cirq/simulator_device.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad95aad...61583e8. Read the comment docs.

@rmoyard rmoyard self-requested a review June 9, 2022 15:28
requirements-ci.txt Outdated Show resolved Hide resolved
Copy link
Contributor

@rmoyard rmoyard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @antalszava, it looks good to me 💯

@rmoyard rmoyard merged commit e42a981 into master Jun 12, 2022
@rmoyard rmoyard deleted the fix_returns_state branch June 12, 2022 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants