Fix the issue with assigning kernels to ops before registering kernels on macOS #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #582 +/- ##
==========================================
- Coverage 98.94% 98.68% -0.27%
==========================================
Files 167 167
Lines 24527 23959 -568
==========================================
- Hits 24269 23644 -625
- Misses 258 315 +57 ☔ View full report in Codecov by Sentry. |
maliasadi
added a commit
to PennyLaneAI/catalyst
that referenced
this pull request
Dec 21, 2023
Fix Issue PennyLaneAI/pennylane-lightning#583 in Catalyst **temporary** until we merge PR PennyLaneAI/pennylane-lightning#582 [sc-52500]
mlxd
approved these changes
Jan 2, 2024
pennylane_lightning/core/src/simulators/lightning_qubit/gates/DynamicDispatcher.hpp
Outdated
Show resolved
Hide resolved
multiphaseCFD
approved these changes
Jan 2, 2024
dime10
pushed a commit
to PennyLaneAI/catalyst
that referenced
this pull request
Jan 2, 2024
Update Lightning tags to PennyLaneAI/pennylane-lightning@489cff7 as the fix PennyLaneAI/pennylane-lightning#582 is now merged into the master branch. PS. This is related to the "temporary" fix in #412
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The addition of arbitrary controlled operations in
lightning.qubit(PR #516) breaks the use of thelightning.qubitC++ API in Catalyst on macOS. This PR fixes the following issue:Fixes #583
[sc-52500]