Get gtest 1.10.0 and parametrize tests #75
Conversation
Codecov Report
@@ Coverage Diff @@
## master #75 +/- ##
=======================================
Coverage 62.80% 62.80%
=======================================
Files 5 5
Lines 121 121
=======================================
Hits 76 76
Misses 45 45 Continue to review full report at Codecov.
|
| int input = std::get<0>(GetParam()); | ||
| int expected = std::get<1>(GetParam()); |
There was a problem hiding this comment.
std::get<0>(GetParam()): is the C++ equivalent of python's a[0] lol
There was a problem hiding this comment.
Thanks @antalszava, looks great!
I'm still not convinced of the benefits of this approach versus the "good old for loop", since for me there is also a cost to this approach of more complexity and less understandable code.
But maybe where this approach shines is in more advanced test cases. I'm good to go with this approach for now.
| } | ||
| TEST_P(Exp2TestFixture, CheckExp2Results) { | ||
| int input = std::get<0>(GetParam()); | ||
| int expected = std::get<1>(GetParam()); |
There was a problem hiding this comment.
Do you get any warnings when using an int type? For me, it was giving a warning of comparing int and size_t.
There was a problem hiding this comment.
Yep, same here, warnings are emitted there.
|
@trbromley agreed that a |
Changes
v1.10.0), see release notes