Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only upload artifacts on pushes to master #76

Merged
merged 1 commit into from
Mar 3, 2021

Conversation

josh146
Copy link
Member

@josh146 josh146 commented Mar 3, 2021

This PR makes the following CI changes:

  • Ensures that deploy is up to date with the latest version of the wheels action
  • Removes unused lines from wheels
  • Modifies the artifact upload to only upload wheels when on the master branch. This will avoid using up storage for every commit in every PR.

@codecov
Copy link

codecov bot commented Mar 3, 2021

Codecov Report

Merging #76 (71b0278) into master (ac4cd5a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #76   +/-   ##
=======================================
  Coverage   62.80%   62.80%           
=======================================
  Files           5        5           
  Lines         121      121           
=======================================
  Hits           76       76           
  Misses         45       45           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac4cd5a...3221f02. Read the comment docs.

Copy link
Contributor

@antalszava antalszava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you so much for catching and resolving this issue! 😊 💯

Comment on lines +40 to +43
# Note: breaking up tests so that no test cases hang on Windows, to be reverted
CIBW_TEST_COMMAND: |
pl-device-test --device=lightning.qubit --skip-ops -x --tb=short --no-flaky-report
pl-device-test --device=lightning.qubit --skip-ops -x --tb=short --no-flaky-report -k "not test_four_qubit_random_circuit"
pl-device-test --device=lightning.qubit --skip-ops -x --tb=short --no-flaky-report -k "test_four_qubit_random_circuit"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎊 Thank you!

@josh146 josh146 merged commit 5b48b7f into master Mar 3, 2021
@josh146 josh146 deleted the remove-commit-artifacts branch March 3, 2021 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants