Added pickle support for lightning.gpu device's DevPool attribute
#772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[sc-66035] |
Jaybsoni
commented
Jun 20, 2024
pennylane_lightning/core/src/simulators/lightning_gpu/bindings/LGPUBindings.hpp
Outdated
Show resolved
Hide resolved
|
Hello. You may have forgotten to update the changelog!
|
Jaybsoni
commented
Jun 20, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #772 +/- ##
==========================================
+ Coverage 90.30% 98.48% +8.17%
==========================================
Files 81 109 +28
Lines 11360 15801 +4441
==========================================
+ Hits 10259 15562 +5303
+ Misses 1101 239 -862 ☔ View full report in Codecov by Sentry. |
Jaybsoni
changed the title
DevPool attributeDevPool attribute
mlxd
reviewed
Jun 21, 2024
maliasadi
requested changes
Jun 21, 2024
pennylane_lightning/core/src/simulators/lightning_gpu/bindings/LGPUBindings.hpp
Show resolved
Hide resolved
maliasadi
reviewed
Jun 21, 2024
Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com>
Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com>
maliasadi
approved these changes
Jun 26, 2024
Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com>
vincentmr
pushed a commit
that referenced
this pull request
Jun 27, 2024
…772) **Context:** Allowing the `qml.device("lightning.gpu", wires=...)._dp` argument, which is a python `DevPools()` object to be pickle-able through the C++ layer. **Description of the Change:** - Updated Devpools object to have a `refresh()` method - Updated TSQueue to have a clear method - Add bindings for pickle to DevPool --------- Co-authored-by: ringo-but-quantum <github-ringo-but-quantum@xanadu.ai> Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Allowing the
qml.device("lightning.gpu", wires=...)._dpargument, which is a pythonDevPools()object to be pickle-able through the C++ layer.Description of the Change:
refresh()method