Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates IBMQ no token test #14

Merged
merged 1 commit into from
Dec 22, 2020
Merged

Updates IBMQ no token test #14

merged 1 commit into from
Dec 22, 2020

Conversation

antalszava
Copy link
Contributor

  1. Updates the IBMQ device no token test to explicitly exclude any environment variables during the test case.
  2. Expands the error message raised when no token was found.

@codecov
Copy link

codecov bot commented Dec 21, 2020 •
edited
Loading

Codecov Report

Merging #14 (5aac580) into main (0850f47) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #14   +/-   ##
=======================================
  Coverage   98.42%   98.42%           
=======================================
  Files          11       11           
  Lines         573      573           
=======================================
  Hits          564      564           
  Misses          9        9
Impacted Files Coverage Δ
pennylane_orquestra/ibmq_device.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0850f47...5aac580. Read the comment docs.

@antalszava antalszava mentioned this pull request Dec 21, 2020
Merged
josh146
josh146 reviewed Dec 22, 2020
View reviewed changes
tests/test_orquestra_device.py
Comment on lines +92 to +95
def test_ibmq_no_token_error(self, monkeypatch):
"""Test that an error is raised when using the IBMQDevice without any
tokens specified."""
monkeypatch.delenv("IBMQX_TOKEN", raising=False)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, this is very subtle!

@antalszava antalszava merged commit fc94fbb into main Dec 22, 2020
@antalszava antalszava deleted the test_ibmq_token branch December 22, 2020 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josh146 josh146 josh146 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@antalszava @josh146