Add the execute and batch_execute methods #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Theodor <theodor@xanadu.ai>
Co-authored-by: Theodor <theodor@xanadu.ai>
Co-authored-by: Theodor <theodor@xanadu.ai>
Co-authored-by: Theodor <theodor@xanadu.ai>
Co-authored-by: Theodor <theodor@xanadu.ai>
Co-authored-by: Theodor <theodor@xanadu.ai>
Co-authored-by: Josh Izaac <josh146@gmail.com>
Co-authored-by: Josh Izaac <josh146@gmail.com>
Co-authored-by: Josh Izaac <josh146@gmail.com>
…nnylane-orquestra into execute_and_batch
thisac
approved these changes
Dec 16, 2020
There was a problem hiding this comment.
Very nice code and testing @antalszava. Just had a few questions and some text-comments (a few docstrings in the tests need to be updated, etc.) 🏅
.github/workflows/tests.yml
Outdated
Comment on lines
51
to
52
| - name: Adjust coverage file for Codecov | ||
| run: bash <(sed -i 's/filename=\"/filename=\"pennylane_orquestra\//g' coverage.xml) |
There was a problem hiding this comment.
Again, just re-iterating what @josh146 said earlier, is this necessary here?
There was a problem hiding this comment.
Oh, thanks so much for catching that! Still remained there somehow (maybe in between branches). Removed.
Co-authored-by: Theodor <theodor@xanadu.ai>
Co-authored-by: Theodor <theodor@xanadu.ai>
…nnylane-orquestra into execute_and_batch
Co-authored-by: Theodor <theodor@xanadu.ai>
Co-authored-by: Theodor <theodor@xanadu.ai>
…nnylane-orquestra into execute_and_batch
Co-authored-by: Theodor <theodor@xanadu.ai>
…nnylane-orquestra into execute_and_batch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
OrquestraDeviceand its subclasses are capable of serializing backend specifications, circuits and operators. There are also auxiliary functions available that make it possible to:gen_workflow.py)cli_actions.py).To put pieces together, executing circuits and computing expectation values of operators remain.
Changes
Adds two device methods:
OrquestraDevice.execute: supports computing expectation values for (an) operator(s) and returning the result(s) to a QNodeOrquestraDevice.batch_execute: supports computing expectation values for batches of circuits (e.g., when computing jacobians and using aJacobianTapewith the new tape mode feature of PennyLane)