Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to circuit.measure instead of using the measure function #191

Merged
merged 2 commits into from
Feb 23, 2022

Conversation

antalszava
Copy link
Contributor

Closes #164.

@codecov
Copy link

codecov bot commented Feb 22, 2022

Codecov Report

Merging #191 (a16c6c0) into master (4b39772) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #191   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          292       291    -1     
=========================================
- Hits           292       291    -1     
Impacted Files Coverage Δ
pennylane_qiskit/qiskit_device.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b39772...a16c6c0. Read the comment docs.

Copy link
Contributor

@rmoyard rmoyard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @antalszava for the change, it looks good to me 💯

@rmoyard rmoyard merged commit 0ecd65d into master Feb 23, 2022
@rmoyard rmoyard deleted the measure_depr branch February 23, 2022 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem with qiskit version 0.33.0 related to the function measure
2 participants