Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for iswap gate #229

Merged
merged 2 commits into from
Sep 19, 2022
Merged

add support for iswap gate #229

merged 2 commits into from
Sep 19, 2022

Conversation

timmysilv
Copy link
Contributor

the ISWAP gate exists in both Qiskit and PennyLane, so this PR adds support for it.

@codecov
Copy link

codecov bot commented Sep 19, 2022

Codecov Report

Merging #229 (68dec13) into master (46b8919) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #229   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          291       291           
=========================================
  Hits           291       291           
Impacted Files Coverage Δ
pennylane_qiskit/qiskit_device.py 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@albi3ro albi3ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this 👍

Just needs a changelog entry, located in ./CHANGELOG.md. Seems like the latest version of the changelog needs to be updated too.

Copy link
Contributor

@antalszava antalszava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! 🎉 As per Christina's suggestion, needs a changelog entry. Approving on condition of that being added here.

@timmysilv timmysilv merged commit e2bf486 into master Sep 19, 2022
@timmysilv timmysilv deleted the iswap-support branch September 19, 2022 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants