Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Cobyla success bool for VQE runtime #231

Merged
merged 3 commits into from
Oct 5, 2022
Merged

Fix Cobyla success bool for VQE runtime #231

merged 3 commits into from
Oct 5, 2022

Conversation

rmoyard
Copy link
Contributor

@rmoyard rmoyard commented Oct 4, 2022

Success attribute is a numpy bool for the COBYLA optimizer and is not JSON serializable. The solution is to cast it to bool

Related issue: PennyLaneAI/pennylane#3130

@codecov
Copy link

codecov bot commented Oct 4, 2022

Codecov Report

Merging #231 (7ef0605) into master (585246f) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #231   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          291       291           
=========================================
  Hits           291       291           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rmoyard
Copy link
Contributor Author

rmoyard commented Oct 4, 2022

[sc-26934]

@rmoyard
Copy link
Contributor Author

rmoyard commented Oct 5, 2022

@antalszava antalszava self-requested a review October 5, 2022 13:56
Copy link
Contributor

@antalszava antalszava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@rmoyard rmoyard merged commit 232c0c5 into master Oct 5, 2022
@rmoyard rmoyard deleted the fix_cobyla branch October 5, 2022 20:38
@timmysilv timmysilv mentioned this pull request Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants