Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to support Operator.eigvals as a method #35

Merged
merged 4 commits into from
Jun 7, 2022
Merged

Update to support Operator.eigvals as a method #35

merged 4 commits into from
Jun 7, 2022

Conversation

albi3ro
Copy link
Contributor

@albi3ro albi3ro commented Jun 6, 2022

Due to PennyLane PR #2498, eigvals is now a method rather than a property.

@albi3ro albi3ro requested a review from rmoyard June 6, 2022 19:14
albi3ro
albi3ro commented Jun 6, 2022
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
rmoyard
rmoyard reviewed Jun 7, 2022
View reviewed changes
Copy link
Contributor

@rmoyard rmoyard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @albi3ro, don't forget to apply black and I think you can remove the support for older PennyLane version and pin the master branch.

@albi3ro
Copy link
Contributor Author

albi3ro commented Jun 7, 2022

I think I'd prefer to just support both versions. It's a pretty cheap check, so I think it's better to support old versions of PennyLane still.

@albi3ro albi3ro requested a review from rmoyard June 7, 2022 16:49
rmoyard
rmoyard approved these changes Jun 7, 2022
View reviewed changes
Copy link
Contributor

@rmoyard rmoyard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @albi3ro, it looks good to me 👍

@rmoyard rmoyard merged commit 9967f0b into master Jun 7, 2022
@rmoyard rmoyard deleted the eigvals-method branch June 7, 2022 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmoyard rmoyard rmoyard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@albi3ro @rmoyard