Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly pin dependencies #112

Merged
merged 9 commits into from
Jun 23, 2022
Merged

Properly pin dependencies #112

merged 9 commits into from
Jun 23, 2022

Conversation

puzzleshark
Copy link
Contributor

@puzzleshark puzzleshark commented Jun 22, 2022

No description provided.

@antalszava
Copy link
Contributor

Hi @puzzleshark, there seems to be an issue with some tests, e.g., https://github.com/PennyLaneAI/pennylane-sf/runs/7011068931?check_suite_focus=true#step:5:40

Also, in requirements-ci.txt, we should be able to get away with listing only the most important packages (see for example the same file for the PennyLane-Qiskit package).

@codecov
Copy link

codecov bot commented Jun 23, 2022

Codecov Report

Merging #112 (fe3b515) into master (8da1571) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #112   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          498       498           
=========================================
  Hits           498       498           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8da1571...fe3b515. Read the comment docs.

requirements-ci.txt Outdated Show resolved Hide resolved
Copy link
Contributor

@antalszava antalszava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍 Thanks :)

@antalszava antalszava merged commit 0faae85 into master Jun 23, 2022
@antalszava antalszava deleted the depends branch June 23, 2022 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants