Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Rotosolve for non-equidistant frequencies in the cost function #2058

Closed
dwierichs opened this issue Dec 22, 2021 · 0 comments · Fixed by #2081
Closed

Implement Rotosolve for non-equidistant frequencies in the cost function #2058

dwierichs opened this issue Dec 22, 2021 · 0 comments · Fixed by #2081
Assignees
Labels
enhancement ✨ New feature or request

Comments

@dwierichs
Copy link
Contributor

Feature details

This is the follow-up step of #1489 , leveraging our paper on general parameter-shift rules and cost function reconstructions to apply Rotosolve not only to functions with arbitrary integral frequency spectrum, but also to non-equidistant frequencies.

Implementation

Essentially, cases have to be tracked but most of the work is done already, as the reconstruction for general frequency spectra is implemented in qml.fourier.reconstruct via #1864 and the 1D minimization does not have to change based for the generalization.
The structure of Rotosolve likely will change a bit, but also code duplication from reconstruct will be removed.

How important would you say this feature is?

2: Somewhat important. Needed this quarter.

Additional information

I'm working on a prototype.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant