Generalize Rotosolve to arbitray-frequency QNodes #2081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
|
[sc-9758] |
Codecov Report
@@ Coverage Diff @@
## master #2081 +/- ##
=======================================
Coverage 99.18% 99.18%
=======================================
Files 226 226
Lines 17380 17388 +8
=======================================
+ Hits 17239 17247 +8
Misses 141 141
Continue to review full report at Codecov.
|
dwierichs
commented
Jan 10, 2022
josh146
requested changes
Jan 11, 2022
There was a problem hiding this comment.
Thanks @dwierichs, this is a great PR to finish the work we started last year on Fourier analysis of variational circuits!
Very nice documentation and logic. I think this is very near merge-ready, the only reason I request changes is
- consider adding a default optimization method to reduce complexity for end-users
- so that we can be clear regarding breaking changes in the changelog 🙂
Co-authored-by: Josh Izaac <josh146@gmail.com>
Co-authored-by: Josh Izaac <josh146@gmail.com>
…to gen-rotosolve-2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the generalization of Rotosolve to arbitrary frequencies, further extending its use cases.
The last generalization #1489 allowed for arbitrary integer-valued frequencies, now any frequency spectra can be tackled.
RotosolveOptimizermakes use ofqml.fourier.reconstructto obtain analytical reconstructions of univariate restrictions of the QNode of interest, and then minimizes this analytical reconstruction, using numerical methods in general and an analytic expression for the minimum for single-frequency functions.This implements #2058.