Device tests run in tape #1026
Merged
Device tests run in tape #1026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
Codecov Report
@@ Coverage Diff @@
## master #1026 +/- ##
==========================================
+ Coverage 95.44% 97.93% +2.49%
==========================================
Files 153 153
Lines 11392 11392
==========================================
+ Hits 10873 11157 +284
+ Misses 519 235 -284
Continue to review full report at Codecov.
|
josh146
reviewed
Jan 22, 2021
| @@ -46,7 +46,7 @@ | |||
| "CSWAP": qml.CSWAP(wires=[0, 1, 2]), | |||
| "CZ": qml.CZ(wires=[0, 1]), | |||
| "CY": qml.CY(wires=[0, 1]), | |||
| "DiagonalQubitUnitary": qml.DiagonalQubitUnitary(np.eye(2), wires=[0]), | |||
| "DiagonalQubitUnitary": qml.DiagonalQubitUnitary(np.array([1, 1]), wires=[0]), | |||
thisac
approved these changes
Jan 22, 2021
pennylane/devices/tests/conftest.py
Outdated
Comment on lines
267
to
272
| @pytest.fixture | ||
| def in_tape_mode(): | ||
| """Run the test in tape mode""" | ||
| qml.enable_tape() | ||
| yield | ||
| qml.disable_tape() |
There was a problem hiding this comment.
Is this ever used in devices/tests? 🤔
There was a problem hiding this comment.
Nope, good catch! Removed.
| @@ -106,7 +106,7 @@ def circuit(theta, phi): | |||
| assert np.allclose(qnode(theta, phi), qnode_def(theta, phi), atol=tol(dev.analytic)) | |||
| assert np.allclose(grad(theta, phi), grad_def(theta, phi), atol=tol(dev.analytic)) | |||
|
|
|||
| @pytest.mark.parametrize("ret", [qml.expval, qml.var]) | |||
| @pytest.mark.parametrize("ret", ["expval", "var"]) | |||
There was a problem hiding this comment.
Why this change? Did it not work before or is this just better/safer?
There was a problem hiding this comment.
Tape mode was activated after ret got its value, so non-tape qml.expval and qml.var were pulled in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
The device test suite runs in tape mode.
Description of the Change:
conftest.pyfile of the device test suiteqml.expval) in the test functions such that the tape version can also be fetched