Update the state original tape device #1049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
Codecov Report
@@ Coverage Diff @@
## master #1049 +/- ##
=======================================
Coverage 97.74% 97.75%
=======================================
Files 153 153
Lines 11508 11512 +4
=======================================
+ Hits 11249 11253 +4
Misses 259 259
Continue to review full report at Codecov.
|
glassnotes
approved these changes
Jan 28, 2021
antalszava
commented
Jan 28, 2021
| """Test that the returned state is equal to the expected returned state for all of | ||
| PennyLane's built in statevector devices""" | ||
|
|
||
| dev = qml.device(device, wires=4) | ||
|
|
||
| @qnode(dev, diff_method="parameter-shift") | ||
| @qnode(dev, diff_method=diff_method) |
There was a problem hiding this comment.
"best" may cover "backprop" too for relevant devices and tests the new behaviour.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
With #1008 devices can be swapped under the hood to get the best differentiation method. This means that certain internal device data may be lost during the QNode call.
Description of the Change:
Updates the
_pre_rotated_stateand_stateprivate attributes of the original device with the device that was actually used during execution.Note: the way of how the state prior to rotations in being stored might not be completely unified between devices and is not a part of the shared device methods (not a member of
QubitDevice). Therefore we are attempting to set the affected attributes, but if they do not exist then no change is done.Benefits:
States are updated even if a different device is used under the hood.
Possible Drawbacks:
None, though might provide a reason to consider a unified name for storing states in statevector simulator devices.
Related GitHub Issues:
#1048