Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds the quantum fourier transform and controlled phase operations #1064
Adds the quantum fourier transform and controlled phase operations #1064
Changes from all commits
b6250aa
e88c3c5
34e845a
af7ae89
fd49f75
247c7e4
d84cbf4
aa79522
f1e1d86
1e22db7
4d1a615
c398358
1c4d331
4d4c06c
37c4010
e62dc18
bbdf9da
b9045a7
552824c
358bcb0
0733f46
0f874fc
c2e7673
16d116e
2566d52
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did check this and can confirm that it's unlike the other CRX, CRY, CRZ gates because the 2-parameter shift works:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When running the QFT, is there a way to make it print out the full decomposition when using
draw
? Currently it draws this:but for the sake of testing it'd be convenient to see the innards.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be the moment that our new
qml.draw()
shines!Since it is not dependent on the QNode state (unlike
qnode.draw()
), we can add some logic toqml.draw()
to always decompose the QFT operation (or maybe any operation that has adraw_decomp
flag or something).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'd be great to have it at the level of the draw function itself -
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or even