Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vqe.py #1077

Merged
merged 1 commit into from Feb 9, 2021
Merged

Update vqe.py #1077

merged 1 commit into from Feb 9, 2021

Conversation

antalszava
Copy link
Contributor

@antalszava antalszava commented Feb 9, 2021

Updates to mention to molecular_hamiltonian in docs after past changes in qchem:

generate_hamiltonian has been renamed to molecular_hamiltonian. The modified function contains an extended docstring that outlines the main steps to build the Hamiltonian.

update `genearate_hamiltonian` refs
@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2021

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@codecov
Copy link

codecov bot commented Feb 9, 2021

Codecov Report

Merging #1077 (0d848ee) into master (12c8927) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1077   +/-   ##
=======================================
  Coverage   97.71%   97.71%           
=======================================
  Files         154      154           
  Lines       11637    11637           
=======================================
  Hits        11371    11371           
  Misses        266      266           
Impacted Files Coverage Δ
pennylane/vqe/vqe.py 93.78% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12c8927...0d848ee. Read the comment docs.

Copy link
Member

@co9olguy co9olguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interestingly, there was one place where it was already changed 🤔

@antalszava antalszava merged commit bf80d65 into master Feb 9, 2021
@antalszava antalszava deleted the antalszava-patch-1 branch February 9, 2021 22:15
@josh146
Copy link
Member

josh146 commented Feb 10, 2021

@antalszava correct me if I'm wrong, but this PR should be included in the v0.14.1 bugfix release?

@josh146 josh146 added this to the v0.14.1 milestone Feb 10, 2021
@co9olguy
Copy link
Member

Just a docs change, so perfectly safe

josh146 pushed a commit that referenced this pull request Feb 12, 2021
update `genearate_hamiltonian` refs
josh146 added a commit that referenced this pull request Feb 12, 2021
* PR 1082

* PR 1072

* Update vqe.py (#1077)

update `genearate_hamiltonian` refs

* PR 1074

* Add jax skip (#1066)

Co-authored-by: Josh Izaac <josh146@gmail.com>

* update changelog

* update version number

* Apply suggestions from code review

Co-authored-by: Tom Bromley <49409390+trbromley@users.noreply.github.com>
Co-authored-by: antalszava <antalszava@gmail.com>

Co-authored-by: antalszava <antalszava@gmail.com>
Co-authored-by: Tom Bromley <49409390+trbromley@users.noreply.github.com>
josh146 added a commit that referenced this pull request Feb 12, 2021
* PR 1082

* PR 1072

* Update vqe.py (#1077)

update `genearate_hamiltonian` refs

* PR 1074

* Add jax skip (#1066)

Co-authored-by: Josh Izaac <josh146@gmail.com>

* update changelog

* update version number

* Update .github/CHANGELOG.md

Co-authored-by: antalszava <antalszava@gmail.com>
Co-authored-by: Tom Bromley <49409390+trbromley@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants