Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added flaky as a dependency for running tests #1113

Merged
merged 7 commits into from
Mar 8, 2021

Conversation

PritishSehzpaul
Copy link
Contributor

Context: Flaky was missing as a required dependency from the doc. Without it make test fails.

Description of the Change: Added flaky as a dependency in the doc and why it is required.

Benefits: Better, more complete documentation.

Possible Drawbacks: None.

Related GitHub Issues: #1099

@codecov
Copy link

codecov bot commented Feb 25, 2021

Codecov Report

Merging #1113 (eb4db57) into master (13aead4) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1113   +/-   ##
=======================================
  Coverage   97.73%   97.74%           
=======================================
  Files         155      155           
  Lines       11760    11760           
=======================================
+ Hits        11494    11495    +1     
+ Misses        266      265    -1     
Impacted Files Coverage Δ
pennylane/circuit_graph.py 98.69% <0.00%> (+0.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13aead4...93ff1b2. Read the comment docs.

Copy link
Member

@josh146 josh146 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @PritishSehzpaul for this contribution! Just left a comment regarding the contributor name ordering in the changelog, but apart from that it looks great and should be ready for merging directly after 🙂

doc/development/guide/tests.rst Outdated Show resolved Hide resolved
.github/CHANGELOG.md Outdated Show resolved Hide resolved
.github/CHANGELOG.md Show resolved Hide resolved
@josh146 josh146 linked an issue Feb 28, 2021 that may be closed by this pull request
Copy link
Member

@josh146 josh146 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @PritishSehzpaul, a recent commit to master corrected the alphabetical ordering of contributors, so this should be good to merge in now. Thanks for the contribution!

@josh146 josh146 merged commit 59e074a into PennyLaneAI:master Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add flaky as a dependency to Software tests page
2 participants