-
Notifications
You must be signed in to change notification settings - Fork 575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added flaky as a dependency for running tests #1113
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1113 +/- ##
=======================================
Coverage 97.73% 97.74%
=======================================
Files 155 155
Lines 11760 11760
=======================================
+ Hits 11494 11495 +1
+ Misses 266 265 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @PritishSehzpaul for this contribution! Just left a comment regarding the contributor name ordering in the changelog, but apart from that it looks great and should be ready for merging directly after 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @PritishSehzpaul, a recent commit to master corrected the alphabetical ordering of contributors, so this should be good to merge in now. Thanks for the contribution!
Context: Flaky was missing as a required dependency from the doc. Without it
make test
fails.Description of the Change: Added
flaky
as a dependency in the doc and why it is required.Benefits: Better, more complete documentation.
Possible Drawbacks: None.
Related GitHub Issues: #1099