Fixes a bug where decompositions would reset the differentiation method of a QNode #1117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1117 +/- ##
=======================================
Coverage 97.74% 97.74%
=======================================
Files 154 154
Lines 11728 11728
=======================================
Hits 11463 11463
Misses 265 265
Continue to review full report at Codecov.
|
antalszava
reviewed
Mar 1, 2021
antalszava
approved these changes
Mar 1, 2021
Co-authored-by: antalszava <antalszava@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: During tape construction, the differentiation options of the tape are set prior to any potential tape expansion. Since tape expansion is a tape-to-tape transformation that outputs a new tape, if a decomposition is required, the tape differentiation options are lost.
Description of the Change: Moves the setting of the differentiation options to after potential tape expansion.
Benefits: Preserves differentiation options, even if a decomposition is performed.
Possible Drawbacks: We plan to move tape expansion to the device, as a result, the logic that causes this bug within the QNode will be removed. This is not a drawback, just something to keep in mind --- an expected future change would have also eliminated this bug!
Related GitHub Issues: Closes #1115