Added conj to qml math, fixed some ops #1143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
Codecov Report
@@ Coverage Diff @@
## master #1143 +/- ##
=======================================
Coverage 97.97% 97.97%
=======================================
Files 142 142
Lines 10279 10289 +10
=======================================
+ Hits 10071 10081 +10
Misses 208 208
Continue to review full report at Codecov.
|
josh146
reviewed
Mar 18, 2021
josh146
approved these changes
Mar 18, 2021
| @@ -605,7 +606,7 @@ def _heisenberg_rep(p): | |||
|
|
|||
| def adjoint(self, do_queue=False): | |||
| U = self.parameters[0] | |||
| return Interferometer(U.conj().T, wires=self.wires, do_queue=do_queue) | |||
| return Interferometer(qml_math.T(qml_math.conj(U)), wires=self.wires, do_queue=do_queue) | |||
Co-authored-by: Josh Izaac <josh146@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
qml.math.conjdidn't exist before. This is needed to make adjoint transforms differentiable.Description of the Change:
Added
qml.math.conjand fixed affected adjoint transforms.Benefits:
qml.math.conjcan now be used, adjoints are now differentiable transforms.Possible Drawbacks:
None
Related GitHub Issues:
None