Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Templates] Rewrite embeddings as operations #1156
[Templates] Rewrite embeddings as operations #1156
Changes from 72 commits
21e30b8
bab8c08
6a62534
25e6085
5074218
23147d6
0f31b36
8b5828a
e13a1e5
f79f20f
f6408fe
f014c89
6d1fb63
33f4c8e
95e35e4
8c7fbc6
14ebf35
643113f
153401d
951b924
0fdf4b4
1d6d32d
24119bc
da62820
4443b57
672d963
f4dc056
4d100f3
c4f609a
f8a2747
5e1df17
be672e3
50b074a
30c3bb1
426c1ed
55e2206
c7f1a41
c1d2874
39e7768
899911b
006bc97
595186d
16ba95c
9c99910
72c688e
7884630
4eb9b76
ebea0b0
b86e613
4cad2e4
c0632db
0343c22
e54694b
a3cf592
840fd79
032d2b1
25555cb
4a08e84
f8762c5
50693b5
bfd2f57
b548100
990d726
a6c2977
b2656d8
319c84d
6a325f0
4994ec3
9171a66
17b7eb1
f9a1feb
da33280
f12f205
985f043
7c70c47
a075755
18fa0e2
38e15ad
258b4d6
5088d98
13147fd
b52f181
9a171c6
898fa00
925e868
d874902
37c0211
6350488
60ed4f8
7ac7d5a
69e7a9c
28c7dcb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using a dict rather than the previous three if statements to check which gate is used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
Wires
class is not user facing, and anIterable
in any case, so taking it out here...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am inconsistent here, but thought the code is more readable if I give the first parameter a name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason why I iterate over a range is that some tensors (tf, if I recall correctly) don't like to be iterated over in something like
for t in tensor
...