-
Notifications
You must be signed in to change notification settings - Fork 575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Fourier coefficient calculation module #1160
Conversation
Hello. You may have forgotten to update the changelog!
|
…nylane into fourier_spectrum
* tests/fourier/test_coefficients.py:
…nto fourier_spectrum
…o tensors instead of arrays, mention interface compatibility
It looks fantastic! |
@glassnotes only one failing test, which is not even related to the module:
Maybe this is caused by |
Agreed! I will make an issue for this. |
Yes I think that's the reason. A temporary fix would be to not enable 64-bit support, and just set the equality threshold at something higher, like |
I can locally run the tests :) Let's see if CI is happy. |
@josh146 sorry for the delay. Happy if we merge? The codecov should only be one import line that is not tested (plus the strange omission of seeing that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep go for it!
Context: The Fourier spectrum of a quantum model can be used to gauge its expressivity, as demonstrated in Schuld, Sweke and Meyer (2020) and Vidal and Theis, 2019.
Description of the Change: A new module,
fourier
, and associated documentation and visualization methods.Note: the visualization tools are being developed in #1198 to keep the review process more manageable.Benefits: Users now have built-in tools and examples for computing the Fourier spectra and coefficients of quantum circuits.
Possible Drawbacks: Spectra are currently only calculated for a subset of possible operations. Further work is required to extend this.
Related GitHub Issues: N/A