No analytic kwarg in device test suite #1216
Conversation
|
Hello. You may have forgotten to update the changelog!
|
|
@mariaschuld started this up, could you confirm if these parts really indeed need to be removed/modified? 🤔 in the process figured that maybe they are meant to be left in until the next release cycle. Will close this if that's the case. |
Codecov Report
@@ Coverage Diff @@
## master #1216 +/- ##
=======================================
Coverage 98.12% 98.12%
=======================================
Files 145 145
Lines 10985 10985
=======================================
Hits 10779 10779
Misses 206 206 Continue to review full report at Codecov.
|
|
Perfect, I totally overlooked this! Thanks! |
| @@ -97,8 +97,7 @@ def get_device_tests(): | |||
|
|
|||
| def test_device( | |||
| device_name, | |||
| analytic=None, | |||
| shots=None, | |||
| shots=0, | |||
There was a problem hiding this comment.
Note: changed to shots=0 because shots=None is now ambiguous. There's no distinction between None being the default and None passed explicitly.
antalszava
requested review from
mariaschuld and
josh146
and removed request for
mariaschuld
antalszava
changed the title
There was a problem hiding this comment.
Thanks @antalszava! Good catch, and good idea to merge this in before the release.
Could you add this PR to the list of PRs already listed in the changelog for the shots refactor? Thanks!
No description provided.